OP-1[Added mobile number payment support with contact access and various ui fixes] - #7
Open
ashish-commit987 wants to merge 2 commits into
Open
OP-1[Added mobile number payment support with contact access and various ui fixes]#7ashish-commit987 wants to merge 2 commits into
ashish-commit987 wants to merge 2 commits into
Conversation
|
@ashish-commit987 is attempting to deploy a commit to the laksh-ya's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
list of features added:
1-Added option of payment to the phone numbers (though payment to phone numbers does not works as intented like in full upi apps because the *99# only checks the numbers registered on bhim upi).
2-Also added the option of the contact sync for payments to the contacts.
3-Revamp the homepage ui.
4-Hides the ussd code running as it makes app look weird hence ussd works behind the app just like real backend 🙂.
5-As ussd got hidden now so there was the problem with the phones that using the button navigation and have the ussd dialer at bottom, in that case ussd sometimes was appearing in that buttons area, so now it also hides the button for few seconds untill we get the response to make it more intuitive.
6-Also added the option of selction of 4digit pin also, as earlier it has generalized 6 digit pin which makes look ui bad for the 4 digits ones.
7-also added the option of setting the default sim for payment- it now actually have 3 options that are sim1,sim2 or ask every time and it is changeable through settings.
8-As now the ussd code is not running in front of users eye, so for this every response generating on screen is rendered through the ussd response so no need to worry about the ussd response got missing.
9-earlier what was happening is that once the user enters the pin then this app was running automatically and user was not able to confirm to whom it is paying(only gets the name at the very lat payment receipt), So to tackle this have added the send button which appear a the step where we use to get the info to whom we are paying and payment only complete once we verify the payee name.
10-there is also the dialog box that appears whenever the user changes his sim so it basically tells the user that your sim has changes so please reconfigure those 3 options that are sim1 as default or sim2 as default or ask every time.
last but not the least i have used ai a lot for coding as i am still learning the kotlin also i use to work on this great project after office hours. So, any feedbacks regarding the code change are most welcomed.
Also i have some more features related ideas for this app we can discuss them just ping me my mail Rajputomsanskar@gmail.com
and forgive me for the bad english 🙂