Skip to content
This repository was archived by the owner on May 20, 2019. It is now read-only.

Update module.ts#33

Open
seanBucholtz wants to merge 1 commit into
lacolaco:masterfrom
seanBucholtz:patch-1
Open

Update module.ts#33
seanBucholtz wants to merge 1 commit into
lacolaco:masterfrom
seanBucholtz:patch-1

Conversation

@seanBucholtz

Copy link
Copy Markdown

Fixes issue #31

Change JitCompilerFactory import from @angular/compiler to @angular/platform-browser-dynamic

Change JITCompilerFactory import from @angular/compiler to @angular/platform-browser-dynamic
@lacolaco

Copy link
Copy Markdown
Owner

I'm so sorry not to be able to merge this patch because this repository is not tested and I'm no longer maintaining this.
I'm not sure about that is correct fix or not.

@lacolaco

Copy link
Copy Markdown
Owner

I think, to maintain this library, I should migrate this to Angular CLI based project.
And I have to fix broken CI setting.
There're many heavy tasks, and I don't have enough time to do that...

@SDAdham

SDAdham commented Sep 23, 2018

Copy link
Copy Markdown

hi @lacolaco , that's alright, i had it tested, and it works at my end if you want to merge it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants