Skip to content

fix: bump to Node 24 to clear Node 20 deprecation warnings#260

Merged
baltoiteodor merged 2 commits into
mainfrom
fix-node20-deprecation
May 15, 2026
Merged

fix: bump to Node 24 to clear Node 20 deprecation warnings#260
baltoiteodor merged 2 commits into
mainfrom
fix-node20-deprecation

Conversation

@sjim-fortinet
Copy link
Copy Markdown
Contributor

@sjim-fortinet sjim-fortinet commented May 14, 2026 •
edited
Loading

Summary

Both runner-Node sources in this composite action emit GitHub's Node 20 deprecation warning (forced to Node 24 by default starting June 2, 2026; Node 20 removed from runners on Sep 16, 2026):

  • `actions/setup-node@v4` — v4 runs on node20
  • The runtime-rewritten `./../lacework-code-security` local action with `runs.using="node16"` — runners silently upgrade node16 to node20

This PR bumps both to Node 24:

  • `actions/setup-node@v4` → `@v6` (v6 uses node24)
  • yq mutation: `runs.using="node16"` → `runs.using="node24"`
  • `node-version: 18` → `24` to match the runtime that ends up executing the compiled JS

Test plan

  • Existing integration-test workflow on this branch should run on Node 24 and pass — the produced `dist/src/index.js` (`@actions/`, `@octokit/`, `simple-git`, `tmp`) is all node24-compatible.

🤖 Generated with Claude Code

@sjim-fortinet @claude
fix: bump to Node 24 to clear deprecation warnings
7ff1d49 
Both runner-Node sources in this composite action were producing the
"Node.js 20 actions are deprecated" warning starting Sep 2025:

- actions/setup-node@v4 (uses node20)
- the runtime-rewritten ./../lacework-code-security action with
  runs.using="node16" (silently upgraded to node20 by the runner)

Update both to node24:
- setup-node@v4 -> @v6 (v6 uses node24)
- runs.using="node16" -> "node24" in the yq mutation
- bump installed node-version 18 -> 24 to match the runtime

Ref: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
baltoiteodor

This comment was marked as resolved.

Sign in to view

@baltoiteodor baltoiteodor self-requested a review May 15, 2026 11:17
@baltoiteodor baltoiteodor merged commit 4720e1a into main May 15, 2026
4 checks passed
@baltoiteodor baltoiteodor deleted the fix-node20-deprecation branch May 15, 2026 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@baltoiteodor baltoiteodor baltoiteodor approved these changes

@Christiaan-de-Wet Christiaan-de-Wet Christiaan-de-Wet approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sjim-fortinet @baltoiteodor @Christiaan-de-Wet