Skip to content

Issue-50-lesson-card-YT-logo#52

Open
owaisbukhari00 wants to merge 3 commits into
labrocadabro:mainfrom
owaisbukhari00:issue-50-lesson-card-YT-logo
Open

Issue-50-lesson-card-YT-logo#52
owaisbukhari00 wants to merge 3 commits into
labrocadabro:mainfrom
owaisbukhari00:issue-50-lesson-card-YT-logo

Conversation

@owaisbukhari00
Copy link
Copy Markdown

@owaisbukhari00 owaisbukhari00 commented Jan 11, 2024

closes #50

added youtube logo with default color. Had to add two classes for better bottom and right position.

added youtube logo with default color. Had to add two classes for better bottom and right position.
Copy link
Copy Markdown
Owner

@labrocadabro labrocadabro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Classes can't be added to index.css... it's auto-generated by Tailwind. Instead you need to add them in the tailwind.config.cjs file. However, I'm not sure you need them in this case. The icon should be inline, which you can do in Pug by wrapping the element in #[]. For example:
a(href=whatever) #[span.text-2xl BIG] anchor text

In this case, you should use the i element for the icon, applying the appropriate classes.

This stackoverflow issue has some suggestions on how to underline the text but not the icon.

@owaisbukhari00
Copy link
Copy Markdown
Author

Thank you, Laura. I haven't worked with Tailwind yet and learning new things. I get your point. I've updated it as an inline element and now onto removing the underline from icon hover.

Will get back to you!

@owaisbukhari00
Copy link
Copy Markdown
Author

Do you think if this icon size is okay?

image

@labrocadabro
Copy link
Copy Markdown
Owner

labrocadabro commented Jan 14, 2024

Looks good to me. :)

@owaisbukhari00
Copy link
Copy Markdown
Author

derline the text but not the icon.

With inline styling, I am unable to remove the underline on hover from YouTube icon so far. I can think of the following approaches:
a. add new class with text-decoration: none
b. create two different elements for text and icon and style them accordingly
c. try inline-block for icon (but not sure if it will work)

Do you think of any better way?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

YouTube logo addition

2 participants