feat: graceful shutdown on SIGINT/SIGTERM#206
Open
prochac wants to merge 1 commit into
Open
Conversation
Propagate context through the fetch layer to cancel in-flight requests on shutdown, and drain the HTTP server before exit. fixed: - run the scrape loop synchronously so ticks coalesce instead of piling up overlapping scrapes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Propagate context through the fetch layer to cancel in-flight requests on shutdown, and drain the HTTP server before exit.
Pull Request Template
Description
Adds graceful shutdown on SIGINT/SIGTERM. The exporter derives a context from
signal.NotifyContext; on signal it shuts down the HTTP server with a boundeddrain and cancels in-flight Cloudflare requests instead of being killed mid-flight.
Also:
overlapping scrapes (also fixes a per-iteration
time.NewTickerleak in theold loop)
context.Cancelederrors in fetch logs so shutdown is quietType of Change
Testing
make pr-testsand all tests passfmt-check,lint(golangci-lint: 0 issues), andbuildpass. Theteststep (
run_e2e.sh) couldn't run in my environment — it requires thevenombinary and a
.envfile, neither available here. Verified manually instead:sent SIGTERM and confirmed clean drain (
Shutdown complete, exit 0); with anin-flight request (routed through a hanging proxy) confirmed the
context.Cancelederror is suppressed (0 error log lines).Code Quality
Additional Notes
No documentation/config changes needed —
cf_timeoutand existing flags areunchanged. Shutdown drain is bounded at 10s; in-flight scrapes are best-effort
and abandoned on exit (their results are discarded anyway).