feat: Refactor media state management with enums and streamline UI#27
Merged
Conversation
Introduce dedicated `GameState`, `MovieState`, and `TvState` enums to define and manage media-specific states (e.g., favorite, active, backlog, completed, total completion). This refactoring simplifies the media editing experience by: - Replacing dedicated edit modals with inline checkboxes that directly toggle media states. - Consolidating state handling logic within the enums (e.g., `label()`, `getValue()`). - Removing the `MediaForm`'s update logic, now focusing solely on creation. Additionally, this commit removes the `spatie/laravel-health` package along with its configurations, migrations, and UI elements, and adds comprehensive feature tests for the new state toggling functionality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce dedicated
GameState,MovieState, andTvStateenums to define and manage media-specific states (e.g., favorite, active, backlog, completed, total completion).This refactoring simplifies the media editing experience by:
label(),getValue()).MediaForm's update logic, now focusing solely on creation.Additionally, this commit removes the
spatie/laravel-healthpackage along with its configurations, migrations, and UI elements, and adds comprehensive feature tests for the new state toggling functionality.