fix: strict title match for submission-to-movie resolution - #48
Open
kuzin wants to merge 1 commit into
Open
Conversation
The IMDb-id-miss fallback reused the general full-text catalog search, which matches summary/sighting text as well as titles. A movie whose synced synopsis happened to mention another title's name (e.g. Downton Abbey's summary references the Titanic) would be treated as "the movie already exists," silently swallowing approved submissions for the real movie and reattaching them to the unrelated one.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tt0120338) was silently reattaching to the Downton Abbey movie page in production, because Downton Abbey's synced synopsis mentions "R.M.S. Titanic."getCatalogMovieByTitleSearch) reused the general catalog full-text search, which matches against movie summaries and sighting text, not just titles. That made an unrelated movie look like "the existing match" for a submission whose title happens to appear in its synopsis.getCatalogMovieByExactTitle) and swapped it in at every call site that decides "does this movie already exist in the catalog" (moderation approval flow, synthetic-sighting resolution, moderation dashboard view links, and the public submission duplicate-hint check).getCatalogMovieByTitleSearchitself is untouched — it's still correct for the public search bar.Test plan
yarn lintyarn tsc --noEmityarn vitest run(235 tests passing, including updated mock inpublic-sighting-submit.test.ts)yarn build