Skip to content

Phase 5: admin storage scan status and retry UI - #18

Merged
kutaelee merged 2 commits into
mainfrom
ulw/volume-auto-scan-phase-5
Mar 6, 2026
Merged

Phase 5: admin storage scan status and retry UI#18
kutaelee merged 2 commits into
mainfrom
ulw/volume-auto-scan-phase-5

Conversation

@kutaelee

@kutaelee kutaelee commented Mar 6, 2026

Copy link
Copy Markdown
Owner

Summary

  • Add volume scan API helper (scanVolume) and scan enqueue test coverage.
  • Surface auto-scan state/progress/error in Admin Storage active volume section.
  • Add retry action for failed auto-scan and periodic refresh while scan is queued/running.

Validation

  • pnpm -C packages/ui test -- --run src/api/volumes.spec.ts
  • pnpm -C packages/ui typecheck

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 304fa8df31

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +139 to +141
if (!activeVolume) return;
if (activeVolume.scan_state !== "queued" && activeVolume.scan_state !== "running") return;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Gate auto-refresh on existing scan job

This polling effect refreshes whenever scan_state is queued/running, but it does not require scan_job_id; since volumes can exist with scan_state='queued' and scan_job_id=NULL (see db/init/03_volumes.sql defaults), Admin Storage can enter an endless 3s /admin/volumes poll loop even when no scan is actually in flight. In that state users get repeated loading flicker and the backend gets unnecessary traffic, so the timer should only run when there is a real job id to track.

Useful? React with 👍 / 👎.

@kutaelee
kutaelee merged commit c4148ec into main Mar 6, 2026
2 checks passed
@kutaelee
kutaelee deleted the ulw/volume-auto-scan-phase-5 branch March 6, 2026 10:18
@kutaelee

kutaelee commented Mar 6, 2026

Copy link
Copy Markdown
Owner Author

Reviewed Codex review note and addressed actionable CI issue (React JSX scope import) in commit d61de7f before merge; rerun CI passed. No remaining inline unresolved threads.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant