Phase 5: admin storage scan status and retry UI - #18
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 304fa8df31
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (!activeVolume) return; | ||
| if (activeVolume.scan_state !== "queued" && activeVolume.scan_state !== "running") return; | ||
|
|
There was a problem hiding this comment.
Gate auto-refresh on existing scan job
This polling effect refreshes whenever scan_state is queued/running, but it does not require scan_job_id; since volumes can exist with scan_state='queued' and scan_job_id=NULL (see db/init/03_volumes.sql defaults), Admin Storage can enter an endless 3s /admin/volumes poll loop even when no scan is actually in flight. In that state users get repeated loading flicker and the backend gets unnecessary traffic, so the timer should only run when there is a real job id to track.
Useful? React with 👍 / 👎.
|
Reviewed Codex review note and addressed actionable CI issue (React JSX scope import) in commit d61de7f before merge; rerun CI passed. No remaining inline unresolved threads. |
Summary
scanVolume) and scan enqueue test coverage.Validation
pnpm -C packages/ui test -- --run src/api/volumes.spec.tspnpm -C packages/ui typecheck