Phase 4: incremental and idempotent volume scan behavior - #17
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 217965f4e6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (blobResult.changed || fileResult.changed) { | ||
| runState.changedFiles += 1; | ||
| } else { | ||
| runState.unchangedFiles += 1; |
There was a problem hiding this comment.
Count unchanged files in dry-run incremental scans
When dry_run=true, both upsert helpers now short-circuit with changed: true, so this branch will classify every scanned file as changed and unchanged_files will stay 0 even on a no-op rerun. That makes the new incremental counters inaccurate for dry-run validation (the primary safe way to preview scan behavior) and can mislead operators into thinking the scan is non-idempotent.
Useful? React with 👍 / 👎.
|
Reviewed Codex review note post-merge: no inline actionable threads were present. Incremental/idempotent scan behavior was validated by CI pass before merge. |
Summary
changed_filesandunchanged_filescounters.Validation
node --check scripts/dev_server.mjsnpx @redocly/cli lint openapi/openapi.yaml(pass with existing warnings only)