Skip to content

Phase 4: incremental and idempotent volume scan behavior - #17

Merged
kutaelee merged 1 commit into
mainfrom
ulw/volume-auto-scan-phase-4
Mar 6, 2026
Merged

Phase 4: incremental and idempotent volume scan behavior#17
kutaelee merged 1 commit into
mainfrom
ulw/volume-auto-scan-phase-4

Conversation

@kutaelee

@kutaelee kutaelee commented Mar 6, 2026

Copy link
Copy Markdown
Owner

Summary

  • Add incremental scan behavior by skipping unchanged file/blob upserts (path+mtime/size hash stable).
  • Extend scan result payload with changed_files and unchanged_files counters.
  • Keep missing-file policy as soft-delete for scanned artifacts to preserve re-run consistency.

Validation

  • node --check scripts/dev_server.mjs
  • npx @redocly/cli lint openapi/openapi.yaml (pass with existing warnings only)

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 217965f4e6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/dev_server.mjs
Comment on lines +562 to +565
if (blobResult.changed || fileResult.changed) {
runState.changedFiles += 1;
} else {
runState.unchangedFiles += 1;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Count unchanged files in dry-run incremental scans

When dry_run=true, both upsert helpers now short-circuit with changed: true, so this branch will classify every scanned file as changed and unchanged_files will stay 0 even on a no-op rerun. That makes the new incremental counters inaccurate for dry-run validation (the primary safe way to preview scan behavior) and can mislead operators into thinking the scan is non-idempotent.

Useful? React with 👍 / 👎.

@kutaelee
kutaelee merged commit 6c89077 into main Mar 6, 2026
2 checks passed
@kutaelee
kutaelee deleted the ulw/volume-auto-scan-phase-4 branch March 6, 2026 10:06
@kutaelee

kutaelee commented Mar 6, 2026

Copy link
Copy Markdown
Owner Author

Reviewed Codex review note post-merge: no inline actionable threads were present. Incremental/idempotent scan behavior was validated by CI pass before merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant