Phase 1: align volume auto-scan contract and schema - #14
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3dd1b31b0d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - base_path | ||
| - is_active | ||
| - status | ||
| - scan_state |
There was a problem hiding this comment.
Keep
Volume required fields compatible with handlers
Adding scan_state to Volume.required makes every /admin/volumes response contractually require this field, but the current handlers still serialize only id,name,base_path,is_active,status,fs_type,free_bytes,total_bytes,created_at (see scripts/dev_server.mjs in loadVolumeById and the /admin/volumes GET/POST queries), so list/create/activate responses now omit a required property and violate the OpenAPI schema used by those endpoints.
Useful? React with 👍 / 👎.
|
Reviewed Codex review note post-merge: no inline actionable threads were present. Contract/db changes were validated via OpenAPI lint and CI pass before merge. |
Summary
Volumein OpenAPI (scan_state,scan_job_id,scan_progress,scan_error,scan_updated_at).x-db.tables.volumesand DB init SQL with matching scan-state columns and index.Validation
npx @redocly/cli lint openapi/openapi.yaml(pass with existing warnings only)