Skip to content

Phase 1: align volume auto-scan contract and schema - #14

Merged
kutaelee merged 1 commit into
mainfrom
ulw/volume-auto-scan-phase-1
Mar 6, 2026
Merged

Phase 1: align volume auto-scan contract and schema#14
kutaelee merged 1 commit into
mainfrom
ulw/volume-auto-scan-phase-1

Conversation

@kutaelee

@kutaelee kutaelee commented Mar 6, 2026

Copy link
Copy Markdown
Owner

Summary

  • Add auto-scan state fields to Volume in OpenAPI (scan_state, scan_job_id, scan_progress, scan_error, scan_updated_at).
  • Align x-db.tables.volumes and DB init SQL with matching scan-state columns and index.
  • Clarify activate endpoint summary to reflect enqueueing auto-scan.

Validation

  • npx @redocly/cli lint openapi/openapi.yaml (pass with existing warnings only)

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3dd1b31b0d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread openapi/openapi.yaml
- base_path
- is_active
- status
- scan_state

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep Volume required fields compatible with handlers

Adding scan_state to Volume.required makes every /admin/volumes response contractually require this field, but the current handlers still serialize only id,name,base_path,is_active,status,fs_type,free_bytes,total_bytes,created_at (see scripts/dev_server.mjs in loadVolumeById and the /admin/volumes GET/POST queries), so list/create/activate responses now omit a required property and violate the OpenAPI schema used by those endpoints.

Useful? React with 👍 / 👎.

@kutaelee
kutaelee merged commit f361289 into main Mar 6, 2026
2 checks passed
@kutaelee
kutaelee deleted the ulw/volume-auto-scan-phase-1 branch March 6, 2026 09:41
@kutaelee

kutaelee commented Mar 6, 2026

Copy link
Copy Markdown
Owner Author

Reviewed Codex review note post-merge: no inline actionable threads were present. Contract/db changes were validated via OpenAPI lint and CI pass before merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant