Enable Convert Selection hotkey functionality#53
Open
idzumiko wants to merge 4 commits into
Open
Conversation
- Mark ConvertSelection hotkey event as handled so it doesn't propagate to the target app - Add sleep after SendCopy() so clipboard is populated before reading - Delete selected text (via Delete key) before retyping in the new layout - Add sleep after SetNextKeyboardLayout() so keys are typed after layout has switched https://claude.ai/code/session_01AqTgwjbq95wKSUUUb3HQQU
- Move all three hotkey textboxes inside the Hotkeys groupBox, positioned inline with their labels (were at x=997, far off-screen to the right) - Expand groupBox to accommodate the textboxes - Remove orphaned hotKeyBox1 control (was the stray '?' / 'None' box) - Add 'Reset to defaults' button that restores all settings to factory values - Shrink form ClientSize to match actual content https://claude.ai/code/session_01AqTgwjbq95wKSUUUb3HQQU
KeyUp events were overwriting currentHotkey, so releasing Shift after pressing Shift+Pause would replace the captured combo with just Shift. Now KeyUp events are ignored during hotkey capture, and the hotkey is only recorded when the non-modifier key is pressed (not while typing modifier-only keys). https://claude.ai/code/session_01AqTgwjbq95wKSUUUb3HQQU
Owner
|
Thanks for the contribution! A few comments:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://claude.ai/code/session_01AqTgwjbq95wKSUUUb3HQQU