Skip to content

Enable Convert Selection hotkey functionality#53

Open
idzumiko wants to merge 4 commits into
kurumpa:developmentfrom
idzumiko:claude/ecstatic-hopper-Sciw0
Open

Enable Convert Selection hotkey functionality#53
idzumiko wants to merge 4 commits into
kurumpa:developmentfrom
idzumiko:claude/ecstatic-hopper-Sciw0

Conversation

@idzumiko
Copy link
Copy Markdown

@idzumiko idzumiko commented Jun 4, 2026

  • Mark ConvertSelection hotkey event as handled so it doesn't propagate to the target app
  • Add sleep after SendCopy() so clipboard is populated before reading
  • Delete selected text (via Delete key) before retyping in the new layout
  • Add sleep after SetNextKeyboardLayout() so keys are typed after layout has switched

https://claude.ai/code/session_01AqTgwjbq95wKSUUUb3HQQU

claude and others added 4 commits June 4, 2026 10:52
- Mark ConvertSelection hotkey event as handled so it doesn't propagate to the target app
- Add sleep after SendCopy() so clipboard is populated before reading
- Delete selected text (via Delete key) before retyping in the new layout
- Add sleep after SetNextKeyboardLayout() so keys are typed after layout has switched

https://claude.ai/code/session_01AqTgwjbq95wKSUUUb3HQQU
- Move all three hotkey textboxes inside the Hotkeys groupBox, positioned
  inline with their labels (were at x=997, far off-screen to the right)
- Expand groupBox to accommodate the textboxes
- Remove orphaned hotKeyBox1 control (was the stray '?' / 'None' box)
- Add 'Reset to defaults' button that restores all settings to factory values
- Shrink form ClientSize to match actual content

https://claude.ai/code/session_01AqTgwjbq95wKSUUUb3HQQU
KeyUp events were overwriting currentHotkey, so releasing Shift after
pressing Shift+Pause would replace the captured combo with just Shift.
Now KeyUp events are ignored during hotkey capture, and the hotkey is
only recorded when the non-modifier key is pressed (not while typing
modifier-only keys).

https://claude.ai/code/session_01AqTgwjbq95wKSUUUb3HQQU
@kurumpa
Copy link
Copy Markdown
Owner

kurumpa commented Jun 5, 2026

Thanks for the contribution! A few comments:

  • .vs/dotSwitcher/ seems to be a user-specific settings folder and contains absolute paths e.g. in WorkspaceRootPath. I don't think it's reasonable to have it in the repository.
  • Claude chat session is not available, I wouldn't mind to skim it.
    Otherwise looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants