Fix parsing of Polygon statement metadata - #46
Open
mfornet wants to merge 1 commit into
Open
Conversation
mfornet
marked this pull request as ready for review
July 30, 2026 13:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a patch which I'm using locally due to some newer errors. Everything was written by codex.
Summary
encodingentry when turningproblem.statementsfields into local statement filesBug
ProblemSession.get_statements_list()currently assumes that every value in each language returned byproblem.statementsis textual statement content.Newer Polygon responses can also contain boolean metadata such as:
The method passes those booleans to
PolygonFile.to_byte(), which calls.encode()and crashes:As a result, commands that enumerate remote files, including
polygon-cli updateandpolygon-cli list, fail for affected problems. The existing loop also incorrectly treats the string-valuedencodingmetadata as a downloadableencoding.texstatement section.Fix
Skip
encodingand any non-string values before constructingPolygonFilestatement entries. Actual statement sections keep using the language's declared encoding, preserving the existing behavior for legacy API responses.Validation
python3 -m unittest discover -s tests -p 'test_*.py' -vpolygon-cli updateagainst a problem containing English and Spanish statements plus the new boolean metadata; the update completed and every tracked file reportedNot changed