fix(ci): suppress pull_request runs on release-please PRs - #77
Merged
Conversation
Release-please PRs opened with GITHUB_TOKEN create action_required workflow runs that never start. Exclude the exact release-output set from ordinary pull_request triggers so those PRs create zero runs. - ci.yml: paths-ignore .release-please-manifest.json, CHANGELOG.md, flake.nix - update-vendor-hash.yml: narrow paths to go.mod/go.sum (vendorHash follows the module graph; version-only flake.nix edits must not run) - Add a drift test that derives the expected output set from release-please-config.json and asserts every PR workflow excludes it Push, tag, release, and workflow_dispatch behavior is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Release-please PRs are opened with
GITHUB_TOKEN, so GitHub createspull_requestworkflow runs that sit inaction_requiredforever. Path filtering is the only native way to create zero runs.This patch applies captain option A for treehouse:
ci.yml:paths-ignorefor the exact release-output set (.release-please-manifest.json,CHANGELOG.md,flake.nix)update-vendor-hash.yml: narrowpathstogo.modandgo.sumonly.vendorHashis a function of the Go module graph; release-please's version-onlyflake.nixedit must not create a runrelease_ci_exclusions_test.go: derives the expected output set fromrelease-please-config.json(go+extra-files) and asserts every PR-triggered workflow excludes the complete set, naming missing pathsPush / tag / release /
workflow_dispatchtriggers are untouched. No dispatcher, tokens, or ruleset changes.Validation
on:key handling)go test -run 'TestPullRequest|TestExpectedRelease' .passesci.ymlRUNSgo.mod/go.sumchange -> both RUNNote on checks
This PR is opened under an explicit captain direct-PR override for the release-please CI rollout. A red
no-mistakes-requiredcheck is expected because no no-mistakes signature is attached. It is not a defect in this change; do not treat it as a merge blocker (no required status checks exist on this repo). Do not merge while other substantive checks are red.