feat: add captain decision brief skill - #1420
Open
joshshaloo wants to merge 2 commits into
Open
Conversation
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
The developer wanted to create a new firstmate skill that generates executive decision briefs for the captain. The skill should trigger when the captain asks for a breakdown, background, or decision analysis of current Captain's Calls requiring their input. It must reconcile current structured decisions with task state to exclude resolved or superseded items, distinguish different decision types (product, engineering-risk, credentials, destructive, operational), and present every unresolved decision with plain-language title, business context, history, underlying problem, realistic options with tradeoffs, impact across multiple dimensions, risks with ratings and mitigations, specific recommendation, and exact approval language the captain can copy. The skill must define technical terms in plain language, preserve PR URLs, identify interactive-only actions, avoid mutating fleet state as a side effect, follow existing skill naming and front matter conventions, and produce either a chat response or a dated decision brief file when requested. After implementation, the change should be committed, validated through no-mistakes to a green PR without merging, using the configured fork for push while PRs target upstream.
What Changed
/decision-briefskill that produces executive summaries of all current Captain's Calls and unresolved decisions requiring captain inputRisk Assessment
✅ Low: Documentation-only change that adds a new read-only skill with proper safety boundaries, follows established patterns, and includes appropriate security guidance without modifying any executable code or existing behavior.
Testing
Validated the captain decision brief skill implementation through 14 automated structural tests, YAML frontmatter parsing, documentation integration checks, content completeness verification, behavioral contract validation, and user intent requirement mapping. All tests pass. Created comprehensive evidence artifacts demonstrating the skill's architecture integration, example output format, and ecosystem fit. The skill is properly integrated into firstmate's skill loading system, follows established conventions, and satisfies all user intent requirements. No product or code failures detected.
Evidence: Skill Integration Validation Script
14 automated validation tests - all passing: ✓ Skill file structure ✓ YAML frontmatter validity ✓ User-invocable flag ✓ Internal metadata ✓ Name matches directory ✓ README.md documentation ✓ AGENTS.md integration ✓ documentation-audiences.json registration ✓ Required content sections ✓ Fleet snapshot infrastructure references ✓ Decision categories defined ✓ Risk rating scale documented ✓ Read-only default behavior ✓ File output location specifiedEvidence: Example Decision Brief Output
Evidence: Architecture Integration Diagram
Evidence: Skill Ecosystem Comparison
Evidence: Comprehensive Test Summary
Pipeline
Updates from git push no-mistakes
✅ **intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
✅ **Review** - passed
✅ No issues found.
✅ **Test** - passed
✅ No issues found.
/tmp/no-mistakes-evidence/01KYWX4H54SKT66B6PXRKF6KPS/skill-integration-validation.sh- 14 automated structural validation testsYAML frontmatter parsing withpython3 -c 'import yaml; ...'README.md skill documentation presence viagrep '/decision-brief' README.mdAGENTS.md trigger pattern viagrep 'decision-brief' AGENTS.mddocumentation-audiences.json registration and alphabetical orderingSkill file structure validation (5 required sections present)Decision category completeness (5 categories defined)Risk rating scale documentation (Low/Medium/High/Critical)Behavioral contract verification (read-only default, optional file write)Convention compliance (frontmatter format, directory structure, documentation)Formatting checks (no tabs, Unix line endings, final newline present)User intent requirement mapping (20 requirements verified)✅ **Document** - passed
✅ No issues found.
✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.