Skip to content

feat(harness): add verified Agy adapter - #1408

Open
sentania wants to merge 5 commits into
kunchenguid:mainfrom
sentania:fm/agy-harness-adapter
Open

feat(harness): add verified Agy adapter#1408
sentania wants to merge 5 commits into
kunchenguid:mainfrom
sentania:fm/agy-harness-adapter

Conversation

@sentania

Copy link
Copy Markdown

Summary

  • Add Anti-Gravity CLI 1.1.8 as a verified Firstmate harness adapter using its persistent interactive TUI so later fm-send steers stay in the same live session.
  • Propagate model, effort, autonomy, metadata, trust handling, resume behavior, supervision signatures, help text, and launch behavior across every supported runtime backend.
  • Add token-bound task-local and primary Stop wake guards that preserve existing .agents content and prevent unrelated Agy sessions from writing Firstmate task state.
  • Scope Agy structural composer detection to recorded Agy sessions so Claude and other harness panes always reach their own classifier.
  • Add executable regression tests, authoritative harness documentation, and dated maintainer-verification evidence.

Safety correction

The first no-mistakes review proved Agy customization roots coexist and verified the end-to-end Stop wake.

A later review found that the structural Agy composer proof could also match a rule and blockquote shape in unrelated Claude output.

The pipeline corrected that by harness-scoping the Agy composer branch across tmux, Herdr, Orca, and cmux, then added cross-harness false-positive regression coverage.

Validation

  • No-mistakes review passed after both authorized safety corrections.
  • No-mistakes test phase passed, including live Agy multi-root hook coexistence, token-bound Stop wake behavior, composer routing, and clean-baseline reconciliation for the two documented pre-existing test exceptions.
  • No-mistakes documentation review passed.
  • The repository lint entry point passed earlier with pinned ShellCheck 0.11.0; the recovery run's lint phase was approved as an environmental no-op because its host exposed ShellCheck 0.9.0 and stopped before source analysis.
  • git diff --check origin/main...origin/fm/agy-harness-adapter passed.

Delivery recovery

No-mistakes validated and pushed dcef547c5ab53f9409e9697ea1439f9759d37c52, but its PR lookup incorrectly associated this branch with unrelated merged PR #1.

The captain authorized direct PR creation from the preserved validated head after gh-axi confirmed that no PR existed for fm/agy-harness-adapter.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: dcef547c5a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread bin/fm-spawn.sh
Comment on lines +1315 to +1317
if [ -e "$TURNEND" ] \
|| { printf '%s\n' "$pane" | grep -Fq 'Read the brief at' \
&& printf '%s\n' "$pane" | grep -Fq 'esc to cancel'; }; then

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Confirm completed Agy secondmate brief delivery

Captain, when --secondmate uses Agy, task-hook creation is skipped by the KIND != secondmate guard, so a fresh launch has no hook that can create $TURNEND. If the initial brief turn starts and finishes between the default 500 ms polls, esc to cancel has already disappeared and this loop times out even though the brief was delivered, causing fm-spawn.sh to report a false launch failure; recognize the completed idle transcript or provide an equivalent completion marker for secondmates.

Useful? React with 👍 / 👎.

@kunchenguid

Copy link
Copy Markdown
Owner

Automated reminder: thanks for the PR! This branch currently has a merge conflict with the base branch.

When you get a chance, please rebase onto (or merge) the latest base branch, resolve the conflict, and push. After that, checks will re-run and the PR will get looked at again.

Noted for firstmate#1408 at dcef547c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants