feat(harness): add verified Agy adapter - #1408
Conversation
…arness misclassification
…er-continuity docs
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dcef547c5a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if [ -e "$TURNEND" ] \ | ||
| || { printf '%s\n' "$pane" | grep -Fq 'Read the brief at' \ | ||
| && printf '%s\n' "$pane" | grep -Fq 'esc to cancel'; }; then |
There was a problem hiding this comment.
Confirm completed Agy secondmate brief delivery
Captain, when --secondmate uses Agy, task-hook creation is skipped by the KIND != secondmate guard, so a fresh launch has no hook that can create $TURNEND. If the initial brief turn starts and finishes between the default 500 ms polls, esc to cancel has already disappeared and this loop times out even though the brief was delivered, causing fm-spawn.sh to report a false launch failure; recognize the completed idle transcript or provide an equivalent completion marker for secondmates.
Useful? React with 👍 / 👎.
|
Automated reminder: thanks for the PR! This branch currently has a merge conflict with the base branch. When you get a chance, please rebase onto (or merge) the latest base branch, resolve the conflict, and push. After that, checks will re-run and the PR will get looked at again. Noted for firstmate#1408 at |
Summary
fm-sendsteers stay in the same live session..agentscontent and prevent unrelated Agy sessions from writing Firstmate task state.Safety correction
The first no-mistakes review proved Agy customization roots coexist and verified the end-to-end Stop wake.
A later review found that the structural Agy composer proof could also match a rule and blockquote shape in unrelated Claude output.
The pipeline corrected that by harness-scoping the Agy composer branch across tmux, Herdr, Orca, and cmux, then added cross-harness false-positive regression coverage.
Validation
git diff --check origin/main...origin/fm/agy-harness-adapterpassed.Delivery recovery
No-mistakes validated and pushed
dcef547c5ab53f9409e9697ea1439f9759d37c52, but its PR lookup incorrectly associated this branch with unrelated merged PR #1.The captain authorized direct PR creation from the preserved validated head after
gh-axiconfirmed that no PR existed forfm/agy-harness-adapter.