fix(spawn): pass max effort to Codex - #1403
Open
JaredHuynhning wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Measured behavior
On 2026-08-01, codex-cli 0.146.0 reported effort support per model. Max was verified for gpt-5.6-sol and gpt-5.6-terra.
A live trivial launch using gpt-5.5 with model_reasoning_effort="max" exited 1 with HTTP 400, error code unsupported_value, parameter reasoning.effort, and an explicit supported-value list of none, low, medium, high, and xhigh. No assistant response or work was produced.
Firstmate deliberately remains model-agnostic instead of maintaining a changing model-capability map. An unsupported model/effort pairing fails loudly and actionably rather than silently clamping or performing work at a different effort.
Validation
The no-mistakes run completed fresh review and fix re-review with no remaining findings, targeted spawn and bootstrap behavior tests, documentation validation, and the pinned repository lint gate.
CI note
This pull request comes from a fork. GitHub requires a maintainer to approve workflow execution, so checks will initially appear as not run.