fix: remove obsolete Pi directory migration - #28
Merged
Conversation
Aviator-Coding
pushed a commit
to Aviator-Coding/dotfiles
that referenced
this pull request
Aug 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Implement the captain-authorized post-PR-27 cleanup for public kunchenguid/dotfiles. Remove the obsolete Pi migration activation in home.nix completely, including its now-unused lib argument, while preserving the fresh declarative out-of-store whole-directory themes and extensions links, individual models.json and settings.json links, immutable package declarations, and Pi privacy/runtime ownership boundaries. Per captain follow-up, delete the dedicated migration/content-assertion test and all wiring rather than replacing it with another source-text test. Validate only the supported fresh declarative configuration using non-activating Nix evaluation/build commands; do not activate, switch, rebuild live configuration, or disturb the independent Calm work.
What Changed
libargument fromhome.nix.Risk Assessment
✅ Low: The change is narrowly scoped and fully matches the authorized cleanup while preserving all required declarative Pi links, immutable package pins, and runtime ownership boundaries.
Testing
Inspected the commit delta and deleted-test references, evaluated all four Pi links and package pins through the configuration, built the Home Manager activation package without activating it, and inspected the generated result; the fresh declarative setup works as intended, privacy boundaries remain intact, and the worktree stayed clean.
Evidence: Fresh declarative Pi configuration evidence
Shows four out-of-store Pi links, immutable package pins, absent migration activation, successful non-activating Home Manager build, and excluded private/runtime paths.Pipeline
Updates from git push no-mistakes
✅ **intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
✅ **Review** - passed
✅ No issues found.
✅ **Test** - passed
✅ No issues found.
git diff --unified=80 9123c4432e7bd0ace329bb9cef3d620f0045a452..7a0a99e3120128e15bb74224886072fc1fb3f646 -- home.nix flake.nix Makefile tests README.mdrg -n "pi-home-manager|migratePiAuthoredDirectories|home-manager|darwinConfigurations|checks" .nix eval --raw '.#darwinConfigurations.mac.config.home-manager.users.kunchen.home.file.".pi/agent/<path>".source'for themes, extensions, models.json, and settings.jsonnix eval --json '.#darwinConfigurations.mac.config.home-manager.users.kunchen.home.activation'with migration-key inspectionnix build --no-link --print-out-paths '.#darwinConfigurations.mac.config.home-manager.users.kunchen.home.activationPackage'Inspected the generated activation script and managed Pi tree for obsolete migration code, expected declarative paths, and excluded private/runtime pathsgit status --shortafter testing✅ **Document** - passed
✅ No issues found.
✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.