fix(object): allow literal underscore in RBAC resource names when parsing inventory IDs#678
fix(object): allow literal underscore in RBAC resource names when parsing inventory IDs#678SAY-5 wants to merge 1 commit into
Conversation
…sing inventory IDs
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: SAY-5 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @SAY-5! |
|
Hi @SAY-5. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
RBAC resource names may contain a literal underscore (for example
roles_ops), butParseObjMetadatarejected such inventory identifiers with a "too many fields" error. The extra-fields check is now skipped for RBAC group kinds, where the remaining segment is unambiguously the name. Closes #487.