Harden CI workflows#475
Closed
tamalsaha wants to merge 1 commit into
Closed
Conversation
Apply the appscode-cloud/installer#1252 hardening pattern: stop using the LGTM_GITHUB_TOKEN PAT for env-based GITHUB_USER / GITHUB_TOKEN pairs; use the default GITHUB_TOKEN with github.actor and add least-privilege job-level permissions. The ghcr.io docker login still uses LGTM_GITHUB_TOKEN since publishing to the appscode-charts org requires cross-org write access. Signed-off-by: Tamal Saha <tamal@appscode.com>
![kodiakhq[bot]](https://avatars.githubusercontent.com/in/29196?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Apply the CI hardening pattern from appscode-cloud/installer#1252.
publish-oci.yml: add least-privilege job permissions (contents: write,packages: write); switch the envGITHUB_USER/GITHUB_TOKENinClone charts repositoryandPublish OCI chartsfrom1gtm/LGTM_GITHUB_TOKENtogithub.actor/GITHUB_TOKEN.release.yml: same env swap inClone charts repositoryandPackage. Job-levelpermissions: contents: writewas already present.update-local-repo.yml: envGITHUB_USER: 1gtm→${{ github.actor }}inUpdate Local Helm repo(GITHUB_TOKENwas already the default).LGTM_GITHUB_TOKENsince publishing to theappscode-chartsorg requires cross-org write access.release-tracker.ymlalready uses the LGTM App token (ownerappscode-cloud, repositoriesCHANGELOG); not touched here.Test plan
release+publish-ociand both succeed.mastertriggersupdate-local-repoand the helm repo update PR is opened as${{ github.actor }}.