Add PVC mode in UI, UI RWO warning and documentation of volumes in Kale - #949
Add PVC mode in UI, UI RWO warning and documentation of volumes in Kale#949ada333 wants to merge 4 commits into
Conversation
…g volumes Signed-off-by: Adam Maly <amaly@redhat.com>
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Signed-off-by: Adam Maly <amaly@redhat.com>
Signed-off-by: Adam Maly <amaly@redhat.com>
Signed-off-by: Adam Maly <amaly@redhat.com>
|
Went through the backend and the new warning path. The 1. The pre-run warning fails open in two ways, and both are silent. const pvcModes = new Map(pvcs.map(p => [p.name, p.access_modes]));
const restrictedVolumes = metadata.volumes.filter(v =>
isRestrictedAccessMode(pvcModes.get(v.name)),
);If a volume in Best-effort is the right call for a warning — but is it worth distinguishing "checked, and it's fine" from "couldn't check"? Right now an RWO volume that 2. The RWO/RWOP set is now hardcoded in two languages.
This is exactly the drift #935 is building 3. /** @deprecated Use isRestrictedAccessMode instead */
export const isReadWriteOnce = isRestrictedAccessMode;It doesn't exist on The |
This PR is followup to mounting volumes in kale #907
Adds docs for user
Fetches PVC mode and displays it in UI - left panel and in the dropdown:
Also adds warning before running the pipeline when some mounted PVC has RWO or RWOP mode:
