docs: Add Event Tracking KEP - #938
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
bb335ad to
a992b54
Compare
Signed-off-by: Adriel Paredes <adriel.paredes@gmail.com>
a992b54 to
e29829b
Compare
jesuino
left a comment
There was a problem hiding this comment.
The KEP is looking good to me, thanks! I have two comments. One is a clarification and the other is a suggestion to avoid an endpoint and to use the existing RPC mechanism in place. Let me know WDYT.
| The frontend simply passes the `trigger` value as part of the existing RPC | ||
| payload. | ||
|
|
||
| Pure UI events (`extension_opened`, `extension_action`) have no corresponding |
There was a problem hiding this comment.
Couldn't we use the in-place RPC mechanism instead calling a new endpoint?
| ### Proposed Events | ||
|
|
||
|
|
||
| | Event | Category | When | |
There was a problem hiding this comment.
There's also the upload event. Please also notice that upload and run events fires compile event, and run also fires upload. Will we fire all the events or a top level event should be enough? In another words if users click run will we also fire upload and compile or a single run event is enough?
Summary
EventTrackerprotocol with a facade pattern — Noop default, zero cost when disabledKey design decisions
EventTrackerprotocol that all entry points (JupyterLab, CLI, core engine) emit events throughkale.tracking.backendsentry points — core Kale has zero vendor dependenciesPOST /kale/api/trackendpointRelated