Make kson-lang for Python wheel-only - #429
Open
holodorum wants to merge 2 commits into
Open
Conversation
Previously artifacts downloaded from CircleCI where Zip folders. Now it was a wheel directly. Update the doc to reflect that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kson-langwraps a native library. The sdist bundled a whole Gradle build so it could try to produce one at install time — a vendored wrapper, abuildSrccopy,MANIFEST.inentries to ship it all, and CI jobs to exercise it.Making and keeping this working added quite a lot of complexity, instead we decided to make wheels the supported way to install, the sdist is source, not a buid.
What this means for users
Installing needs a published wheel. When none matches, pip falls back to the sdist and it refuses immediately with a pointer to building from source, rather than failing part-way through a Gradle run:
The sdist still goes to PyPI. It puts the source there; every installable artifact is a wheel.