Build and CI maintenance - #428
Open
holodorum wants to merge 4 commits into
Open
Conversation
We were blowing up CI because native-image was asking for a memory allocation based on the machine it was running on, rather than the resources it was granted on that machine. Restrict to values that we know will fit in the overhead we are granted.
Windows checkouts of the suite use core.autocrlf, which leaked CRLFs into the generated JsonSuiteTest.kt.
CircleCI retired the Intel macOS fleet, and Xcode 14.2 only existed on Intel, so the job was rejected as having no valid resource class. Use the same executor as build-macos-arm64.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four independent build fixes that landed on
release/0.3.0Restrict native-image resource demands
native-imagesized its memory allocation from the machine it was running on rather than the resources it was granted on that machine, which was blowing up CI. Restricted to-J-Xmx2560mand--parallelism=2, values known to fit inthe overhead we are granted.
Normalize CRLF in JSONTestSuite when generating
Windows checkouts of the vendored suite use
core.autocrlf, which leaked CRLFs into the generatedJsonSuiteTest.kt. Normalized to\nat read time so the generated file does not depend on the checkout's line-ending settings.Run build-python-sdist on a large executor
Bumps the job to
resource_class: large.Run test-python-sdist-macos on Apple silicon
CircleCI retired the Intel macOS fleet, and Xcode 14.2 only existed on Intel, so the job was rejected as having no valid resource class. Moved to Xcode 16.4.0 on
m4pro.medium, the same executor asbuild-macos-arm64.