Skip to content

Update release docs with -Prelease=true - #426

Open
dmarcotte wants to merge 1 commit into
kson-org:mainfrom
dmarcotte:fix-release-flag-docs
Open

Update release docs with -Prelease=true#426
dmarcotte wants to merge 1 commit into
kson-org:mainfrom
dmarcotte:fix-release-flag-docs

Conversation

@dmarcotte

Copy link
Copy Markdown
Contributor

Our maven publish requires a -Prelease=true flag since 17b70cb. Update the documentation to reflect that.

Our maven publish requires a `-Prelease=true` flag since 17b70cb.
Update the documentation to reflect that.

@joeslice joeslice left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with one suggestion (ignore or accept at your discretion).

Comment thread docs/release_process.md
./gradlew publishAllPublicationsToMavenCentralRepository -Prelease=true
```

Note that without `-Prelease=true` both artifacts will be have snapshot coordinates (`X.Y.Z-{gitSha}-SNAPSHOT`) instead of the release version.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change makes sense without this comment. Feel free to leave it but for the sake of the person following the runbook it might not be necessary. In my other changes to the document I've been trying to avoid commentary about the "why" unless it's really important and answering a reader-will-definitely-ask-this question.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants