fix: Build the Action's argument list with if blocks - #8
Merged
Conversation
`[ cond ] && args+=(...)` returns non-zero when the condition is false, which fails the whole step under bash -e if it is ever the last line. The Action survived only because a node command followed it. Same defect class the release workflow hit on its first run. Releases 1.0.3. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RoMv1uCaJQPs44rFX5XWEm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Releases 1.0.3.
action.ymlbuilt its flags with[ cond ] && args+=(...). That returns non-zero when the condition is false, and underbash -ea non-zero last line fails the step. It has been safe only by accident of ordering, since anodecommand follows it — adding a flag at the end would have broken the Action for every consumer. The release workflow hit exactly this defect class on its first run, which is what prompted the audit.Conditions are now
ifblocks. No diagnostic changes.🤖 Generated with Claude Code
https://claude.ai/code/session_01RoMv1uCaJQPs44rFX5XWEm