Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions tools/check-npm-resolution/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -72,13 +72,21 @@ const ngNewApp = () => ({
}
});

/** An application that already depends on the Angular packages `@koobiq/components` peers on. */
/**
* An application that already depends on the Angular packages `@koobiq/components` peers on.
*
* The two extra peers carry the same range shape as the rest of the fixture, not this repository's
* exact pins. Mixing the two makes the fixture contradict itself the moment Angular publishes a
* patch: everything inherited from `ngNewApp()` floats to the new version, while an exact
* `@angular/animations` holds `@angular/core` back — `@angular/animations@x.y.z` peers on
* `@angular/core@x.y.z` exactly — and npm fails on a conflict no `@koobiq/*` package takes part in.
*/
const angularAppWithPeers = () => ({
...ngNewApp(),
dependencies: {
...ngNewApp().dependencies,
'@angular/animations': angularVersion,
'@angular/cdk': cdkVersion
'@angular/animations': angularRange,
'@angular/cdk': ngNewRange(cdkVersion)
}
});

Expand Down