fix(list,select): disabled and selected (#DS-5375) - #1864
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses a visual/state issue where options/items that are both selected and disabled don’t render correctly in List and Select components, and adds new E2E fixtures/screenshots to cover the scenario.
Changes:
- Add new E2E demo components for “selected + disabled” scenarios in
listandselect. - Add Playwright visual regression tests for the new fixtures.
- Update SCSS themes to apply the selected background when an option is both
kbq-selectedandkbq-disabled.
Reviewed changes
Copilot reviewed 7 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/e2e/routes.ts | Registers new E2E components in routing (currently includes an invalid/undefined component reference). |
| packages/components/select/e2e.ts | Adds E2eSelectSelectionState fixture for selected+disabled options inside kbq-select. |
| packages/components/select/e2e.playwright-spec.ts | Adds visual regression test for the new select fixture (light-only currently). |
| packages/components/list/e2e.ts | Adds E2eListSelectionState fixture for selected+disabled list options (uses ngModel). |
| packages/components/list/e2e.playwright-spec.ts | Adds visual regression test for the new list fixture (light-only currently). |
| packages/components/list/_list-theme.scss | Adds selected+disabled background overrides for list options (single and multiple). |
| packages/components/core/option/_option-theme.scss | Adds selected+disabled background overrides for core options (single and multiple). |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Visit the preview URL for this PR (updated for commit 8215684): https://koobiq-next--prs-1864-og1hywwb.web.app (expires Thu, 13 Aug 2026 11:52:46 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c |
🚨 E2E tests failedReview the report for details. 💡 Comment |
🚨 E2E tests failedReview the report for details. 💡 Comment |
|
/approve-snapshots |
|
🔄 Updating snapshots. |
|
🚨 Failed to update snapshots. |
|
/approve-snapshots |
|
🔄 Updating snapshots. |
|
🚨 Failed to update snapshots. |
|
/approve-snapshots |
|
🔄 Updating snapshots. |
|
🚨 Failed to update snapshots. |
#1855