Skip to content

Update nanogui and use our own mainloop#221

Open
petterarvidsson wants to merge 4 commits into
masterfrom
feature-stop-using-nanogui-main-loop
Open

Update nanogui and use our own mainloop#221
petterarvidsson wants to merge 4 commits into
masterfrom
feature-stop-using-nanogui-main-loop

Conversation

@petterarvidsson

Copy link
Copy Markdown
Member

To make it easy to follow nanogui development, remove our changes and instead implement a simple main loop of our won based on: https://github.com/wjakob/nanogui/blob/master/src/example3.cpp

Also replace nanogui dependency with the one directly from https://github.com/wjakob/nanogui

@petterarvidsson

Copy link
Copy Markdown
Member Author

@nsg What do you think?

@petterarvidsson petterarvidsson force-pushed the feature-stop-using-nanogui-main-loop branch from 370a845 to 22687ed Compare November 11, 2016 11:06
@petterarvidsson

Copy link
Copy Markdown
Member Author

Apparently they moved from glew to glad for windows compatibility... ugh...

@petterarvidsson petterarvidsson force-pushed the feature-stop-using-nanogui-main-loop branch from 9041a8f to 715f31b Compare November 11, 2016 15:29
@nsg

nsg commented Nov 12, 2016

Copy link
Copy Markdown
Member

@petterarvidsson Looks good, a little work to keep all these callbacks up-2-date in the future but over all this is a good thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants