feat: support service module system vars and auto module deletion#4771
Open
Cynthia-0203 wants to merge 5 commits into
Open
feat: support service module system vars and auto module deletion#4771Cynthia-0203 wants to merge 5 commits into
Cynthia-0203 wants to merge 5 commits into
Conversation
Cynthia-0203
force-pushed
the
feat/service-module-management
branch
from
81ffd5d to
3d33c4f
Compare
Signed-off-by: Min Min <jamsman94@gmail.com>
Signed-off-by: Min Min <minmin@Mins-MacBook-Pro.local>
Signed-off-by: Cynthia <chenchen@koderover.com>
Signed-off-by: Cynthia <chenchen@koderover.com>
Signed-off-by: Cynthia <chenchen@koderover.com>
Cynthia-0203
force-pushed
the
feat/service-module-management
branch
from
89f9fd8 to
e7e46c1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: this PR depends on the custom resource support PR #4747.
What this PR does / Why we need it:
This PR improves service module management based on the custom resource support work.
It adds system variables for service module images, so each detected service module can expose an image variable like
$<module-name>-image$.It also adds support for deleting auto-discovered service modules by ID. This is useful when automatically parsed modules are no longer needed or need to be cleaned up manually.
What is changed and how it works?
$<module-name>-image$variable is generated from the module image.Does this PR introduce a user-facing change?
This change is