[RG34XXSP] Permanently unbind unused USB1-3 host controllers at boot - #101
Open
agluszyk wants to merge 1 commit into
Open
[RG34XXSP] Permanently unbind unused USB1-3 host controllers at boot#101agluszyk wants to merge 1 commit into
agluszyk wants to merge 1 commit into
Conversation
USB host controllers 1/2/3 (ehci1-3/ohci1-3) are not physically wired on the rg34xx-sp board - usbc1/2/3 in the devicetree carry usb_host_init_state=1 and no drvvbus-supply regulator (only usbc0, the real OTG/charging port, has one - see rg34xx-sp.dts), so nothing can ever be attached to them.
agluszyk
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
USB host controllers 1/2/3 (ehci1-3/ohci1-3) are not physically wired on the
rg34xx-sp board —
usbc1/usbc2/usbc3in the devicetree carryusb_host_init_state=1and nodrvvbus-supplyregulator (onlyusbc0, thereal OTG/charging port, has one — see
rg34xx-sp.dts), so nothing can everbe attached to them.
What
Permanently unbind these three unused host controllers from their drivers at
boot (rg34xx-sp only), via a board-scoped
init.dscript.Impact
Reduces running and suspend (to memory) power draw by gating clocks/PHYs for
controllers that can never have anything attached. No functional downside, the ports are unusable regardless of driver binding.
Testing
boot with no dmesg errors.