Skip to content

add workflow demo - #14

Closed
Eloy-knowledgestack wants to merge 1 commit into
knowledgestack:mainfrom
Eloy-knowledgestack:main
Closed

add workflow demo#14
Eloy-knowledgestack wants to merge 1 commit into
knowledgestack:mainfrom
Eloy-knowledgestack:main

Conversation

@Eloy-knowledgestack

@Eloy-knowledgestack Eloy-knowledgestack commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Summary

Type of change

  • 🚀 New flagship (flagships/<name>/)
  • 🧑‍🍳 New recipe (recipes/<name>/)
  • 🔌 New framework integration (LangChain, LangGraph, CrewAI, Temporal, …)
  • 🐛 Bug fix
  • 📖 Documentation / wiki
  • 🧰 Tooling / CI / dev setup
  • 🧹 Refactor (no behavior change)
  • 💥 Breaking change (describe migration in "Notes")

Related issues

What changed

How to review

# e.g.
CORPUS_FOLDER_ID=<your-folder> make demo-<slug>

Test plan

  • make lint passes
  • make test passes (MCP unit tests)
  • make demo-<slug> runs end-to-end (if flagship/recipe work)
  • Screenshots / sample output attached (if UI-ish or format change)

Checklist

  • I've read CONTRIBUTING.md and the relevant cursor rule
  • No API keys, tokens, or PII in the diff
  • Every non-trivial claim in the agent output is cited (Citation.chunk_id or [chunk:<uuid>])
  • Seed-data expectations documented (either in the flagship README or updating the Seed data wiki page)
  • Workspace pyproject.toml updated if a new package was added
  • Makefile target added/updated if a new flagship was added
  • CHANGELOG.md updated under [Unreleased]

Notes

@Eloy-knowledgestack
Eloy-knowledgestack requested a review from a team as a code owner July 9, 2026 07:08

@frankgu968 frankgu968 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Please remove all the redundant code in step 1,2a,2b,3 and consolidate into a single cli script for someone to run easily
  2. Strip all chinese in here. This repository should be all in english.
  3. Annotate the code clearly in english to indicate how the user can run the workflow.

from pathlib import Path
from typing import cast

from adverse_event_narrative.agent import draft_narrative

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't modify the styling of files that are unrelated to your changes

@@ -0,0 +1,2 @@
#additional requirements:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this committed by mistake? or is this required in the demo?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's an uploaded file for demo

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dont' include any outputs; especially files that are internal to our system!

@Eloy-knowledgestack

Copy link
Copy Markdown
Contributor Author

Roger i will improve those asap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants