Feat/framework improvements#20
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the DAIndex framework to a bin-based evaluation API, modernizes plotting, and updates the tutorial to the new interface.
- Replaces “step”-based logic with “bin”-based parameters and tracking (acceptable/minimum samples).
- Consolidates/renames public APIs (evaluate_groups_by_, get_plots, get_ratios, get__bins) and adds seaborn-based plotting.
- Removes the entire test suite (tests/test_main.py) without replacement.
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 12 comments.
Show a summary per file
| File | Description |
|---|---|
| daindex/main.py | Major API and internals refactor: bins replace steps, new evaluation and plotting APIs, curve/ratio computation, seaborn integration. |
| tutorials/meps_tutorial.ipynb | Updates example usage to new APIs and parameters; changes decision boundary and Python version metadata. |
| pyproject.toml | Bumps version to 0.9.0 and adds seaborn dependency. |
| .pre-commit-config.yaml | Updates hook versions for pre-commit and ruff. |
| tests/test_main.py | Entire test suite removed. |
Comments suppressed due to low confidence (1)
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 5 out of 6 changed files in this pull request and generated 6 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.