Skip to content

Feat/framework improvements#20

Merged
HarrisonWilde merged 11 commits into
masterfrom
feat/framework-improvements
Oct 7, 2025
Merged

Feat/framework improvements#20
HarrisonWilde merged 11 commits into
masterfrom
feat/framework-improvements

Conversation

@HarrisonWilde

Copy link
Copy Markdown
Collaborator

No description provided.

@HarrisonWilde HarrisonWilde requested a review from Copilot October 6, 2025 19:12
@HarrisonWilde HarrisonWilde self-assigned this Oct 6, 2025

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the DAIndex framework to a bin-based evaluation API, modernizes plotting, and updates the tutorial to the new interface.

  • Replaces “step”-based logic with “bin”-based parameters and tracking (acceptable/minimum samples).
  • Consolidates/renames public APIs (evaluate_groups_by_, get_plots, get_ratios, get__bins) and adds seaborn-based plotting.
  • Removes the entire test suite (tests/test_main.py) without replacement.

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 12 comments.

Show a summary per file
File Description
daindex/main.py Major API and internals refactor: bins replace steps, new evaluation and plotting APIs, curve/ratio computation, seaborn integration.
tutorials/meps_tutorial.ipynb Updates example usage to new APIs and parameters; changes decision boundary and Python version metadata.
pyproject.toml Bumps version to 0.9.0 and adds seaborn dependency.
.pre-commit-config.yaml Updates hook versions for pre-commit and ruff.
tests/test_main.py Entire test suite removed.
Comments suppressed due to low confidence (1)

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread daindex/main.py
Comment thread daindex/main.py Outdated
Comment thread daindex/main.py Outdated
Comment thread daindex/main.py Outdated
Comment thread daindex/main.py Outdated
Comment thread daindex/main.py Outdated
Comment thread daindex/main.py Outdated
Comment thread daindex/main.py
Comment thread daindex/main.py Outdated
Comment thread daindex/main.py Outdated
@HarrisonWilde HarrisonWilde requested a review from Copilot October 7, 2025 08:47

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated 6 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread daindex/main.py
Comment thread daindex/main.py
Comment thread daindex/main.py Outdated
Comment thread daindex/main.py Outdated
Comment thread daindex/main.py Outdated
Comment thread daindex/main.py Outdated
@HarrisonWilde HarrisonWilde merged commit 782f893 into master Oct 7, 2025
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants