Skip to content

Flexibility improvements#19

Merged
HarrisonWilde merged 6 commits into
masterfrom
flexibility-improvements
Jul 25, 2025
Merged

Flexibility improvements#19
HarrisonWilde merged 6 commits into
masterfrom
flexibility-improvements

Conversation

@HarrisonWilde

Copy link
Copy Markdown
Collaborator

No description provided.

@HarrisonWilde HarrisonWilde requested a review from Copilot July 25, 2025 22:56
@HarrisonWilde HarrisonWilde self-assigned this Jul 25, 2025

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements flexibility improvements to the DAIndex framework by adding better access methods for step analysis, configurable decision boundaries, and improved documentation.

  • Added new methods to access step sample information, sub-optimal steps, and failed steps for individual groups and all groups
  • Introduced configurable decision boundary parameter for DA curve calculations
  • Enhanced documentation with better method descriptions and parameter explanations

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tutorials/meps_tutorial.ipynb Updated tutorial to demonstrate new API methods and configuration options
pyproject.toml Version bump from 0.7.3 to 0.8.0
daindex/util.py Enhanced documentation for area_under_curve function
daindex/main.py Added new methods for accessing step information and renamed existing methods for consistency
.pre-commit-config.yaml Reordered pre-commit hooks configuration
Comments suppressed due to low confidence (2)

daindex/main.py:500

  • [nitpick] The variable name sub_opt_steps uses an abbreviation. Consider using the full name sub_optimal_steps for consistency with the class attribute naming pattern.
        sub_opt_steps = {s[0]: s[1] for s in ret if s[3]}

daindex/main.py:508

  • [nitpick] The variable name sub_opt_list uses an abbreviation. Consider using sub_optimal_list for consistency with the method naming pattern.
        sub_opt_list = ", ".join([f"{s[0]}: {s[1]}" for s in ret if s[3]])

Comment thread daindex/main.py
Comment on lines +144 to +145
The results can be accessed using the `get_group_ratio` and `get_group_figure` methods (with a reference and
other group), or printed using the `present_results` and `present_all_results` methods.

Copilot AI Jul 25, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation update refers to get_group_ratios and get_group_figures as renamed methods, but should clarify that these are the new method names replacing the old ones to avoid confusion.

Suggested change
The results can be accessed using the `get_group_ratio` and `get_group_figure` methods (with a reference and
other group), or printed using the `present_results` and `present_all_results` methods.
The results can be accessed using the `get_group_ratios` and `get_group_figures` methods (with a reference and
other group). These are the new method names replacing the old `get_group_ratio` and `get_group_figure` methods,
to ensure consistency. Results can also be printed using the `present_results` and `present_all_results` methods.

Copilot uses AI. Check for mistakes.
@HarrisonWilde HarrisonWilde merged commit 00ebe72 into master Jul 25, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants