Skip to content

feat: Remove minimal js-cookie dependency entirely#1451

Closed
andy-knock wants to merge 1 commit into
graphite-base/1451from
remove-js-cookie
Closed

feat: Remove minimal js-cookie dependency entirely#1451
andy-knock wants to merge 1 commit into
graphite-base/1451from
remove-js-cookie

Conversation

@andy-knock
Copy link
Copy Markdown
Contributor

Description

** Describe what, why and how of the changes clearly and concisely. Add any additional useful context or info, as necessary. **

Todos

** List any todo items necessary before merging, if any. Delete if none. **

  • Sample todo item 1
  • Sample todo item 2

Tasks

** Link to task(s) which this PR corresponds to. Example: KNO-54 **

Screenshots

** Attach any screenshots or recordings to visually illustrate the changes, as necessary. Delete if not relevant. **

@vercel
Copy link
Copy Markdown

vercel Bot commented May 26, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Canceled Canceled May 26, 2026 4:32pm

Request Review

Copy link
Copy Markdown
Contributor Author

andy-knock commented May 26, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@andy-knock andy-knock changed the base branch from upgrade-js-cookie to graphite-base/1451 May 26, 2026 16:26
@andy-knock andy-knock force-pushed the graphite-base/1451 branch from 2ffb8b2 to 561e223 Compare May 26, 2026 16:26
@andy-knock andy-knock changed the base branch from graphite-base/1451 to main May 26, 2026 16:26
@andy-knock andy-knock changed the base branch from main to graphite-base/1451 May 26, 2026 16:27
@andy-knock andy-knock changed the base branch from graphite-base/1451 to upgrade-js-cookie May 26, 2026 16:27
@andy-knock andy-knock changed the base branch from upgrade-js-cookie to graphite-base/1451 May 26, 2026 16:27
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 671507f. Configure here.

Comment thread yarn.lock
integrity sha512-z/wZZgDrkNV1eA0ULjM/F9/50Ya8fbzgKneSpoPsXSGd0KnpdtHfOZWK+GcwLk+EZbS4F9RBhU+K2RgzuDaItw==

=======
>>>>>>> a2eb14be (feat: Remove minimal js-cookie dependency entirely)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unresolved merge conflict markers in yarn.lock

High Severity

The yarn.lock file contains unresolved git merge conflict markers (<<<<<<< HEAD, =======, >>>>>>> a2eb14be). This will cause yarn install to fail with a parse error, breaking builds and CI for anyone pulling this branch.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 671507f. Configure here.

Comment thread package.json
},
"devDependencies": {
"@types/gtag.js": "^0.0.5",
"@types/js-cookie": "^3.0.6",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Runtime js-cookie dependency not removed from package.json

Medium Severity

The PR removes the js-cookie import from lib/attribution.ts and drops @types/js-cookie from devDependencies, but the runtime js-cookie package remains in dependencies (line 55 of package.json). This leaves an unused dependency in the bundle, contradicting the PR's stated goal of removing js-cookie entirely.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 671507f. Configure here.

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 671507f. Configure here.

Comment thread yarn.lock
integrity sha512-z/wZZgDrkNV1eA0ULjM/F9/50Ya8fbzgKneSpoPsXSGd0KnpdtHfOZWK+GcwLk+EZbS4F9RBhU+K2RgzuDaItw==

=======
>>>>>>> a2eb14be (feat: Remove minimal js-cookie dependency entirely)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unresolved merge conflict markers in yarn.lock

High Severity

Git merge conflict markers (<<<<<<< HEAD, =======, >>>>>>> a2eb14be) were committed into yarn.lock. This will cause yarn install to fail with a parse error, breaking CI/CD pipelines and local development for anyone pulling this branch.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 671507f. Configure here.

Comment thread package.json
},
"devDependencies": {
"@types/gtag.js": "^0.0.5",
"@types/js-cookie": "^3.0.6",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

js-cookie runtime dependency not removed from package.json

Medium Severity

The PR removes the only import of js-cookie (in lib/attribution.ts) and removes @types/js-cookie from devDependencies, but js-cookie itself is still listed in dependencies (at line 55 of package.json). This leaves an unused runtime dependency in the bundle, contradicting the PR's stated goal of removing the js-cookie dependency entirely.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 671507f. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant