feat: Remove minimal js-cookie dependency entirely#1451
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
a85c23c to
6f70280
Compare
2ffb8b2 to
561e223
Compare
6f70280 to
a2eb14b
Compare
a2eb14b to
671507f
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 671507f. Configure here.
| integrity sha512-z/wZZgDrkNV1eA0ULjM/F9/50Ya8fbzgKneSpoPsXSGd0KnpdtHfOZWK+GcwLk+EZbS4F9RBhU+K2RgzuDaItw== | ||
|
|
||
| ======= | ||
| >>>>>>> a2eb14be (feat: Remove minimal js-cookie dependency entirely) |
There was a problem hiding this comment.
Unresolved merge conflict markers in yarn.lock
High Severity
The yarn.lock file contains unresolved git merge conflict markers (<<<<<<< HEAD, =======, >>>>>>> a2eb14be). This will cause yarn install to fail with a parse error, breaking builds and CI for anyone pulling this branch.
Reviewed by Cursor Bugbot for commit 671507f. Configure here.
| }, | ||
| "devDependencies": { | ||
| "@types/gtag.js": "^0.0.5", | ||
| "@types/js-cookie": "^3.0.6", |
There was a problem hiding this comment.
Runtime js-cookie dependency not removed from package.json
Medium Severity
The PR removes the js-cookie import from lib/attribution.ts and drops @types/js-cookie from devDependencies, but the runtime js-cookie package remains in dependencies (line 55 of package.json). This leaves an unused dependency in the bundle, contradicting the PR's stated goal of removing js-cookie entirely.
Reviewed by Cursor Bugbot for commit 671507f. Configure here.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 671507f. Configure here.
| integrity sha512-z/wZZgDrkNV1eA0ULjM/F9/50Ya8fbzgKneSpoPsXSGd0KnpdtHfOZWK+GcwLk+EZbS4F9RBhU+K2RgzuDaItw== | ||
|
|
||
| ======= | ||
| >>>>>>> a2eb14be (feat: Remove minimal js-cookie dependency entirely) |
There was a problem hiding this comment.
Unresolved merge conflict markers in yarn.lock
High Severity
Git merge conflict markers (<<<<<<< HEAD, =======, >>>>>>> a2eb14be) were committed into yarn.lock. This will cause yarn install to fail with a parse error, breaking CI/CD pipelines and local development for anyone pulling this branch.
Reviewed by Cursor Bugbot for commit 671507f. Configure here.
| }, | ||
| "devDependencies": { | ||
| "@types/gtag.js": "^0.0.5", | ||
| "@types/js-cookie": "^3.0.6", |
There was a problem hiding this comment.
js-cookie runtime dependency not removed from package.json
Medium Severity
The PR removes the only import of js-cookie (in lib/attribution.ts) and removes @types/js-cookie from devDependencies, but js-cookie itself is still listed in dependencies (at line 55 of package.json). This leaves an unused runtime dependency in the bundle, contradicting the PR's stated goal of removing the js-cookie dependency entirely.
Reviewed by Cursor Bugbot for commit 671507f. Configure here.



Description
** Describe what, why and how of the changes clearly and concisely. Add any additional useful context or info, as necessary. **
Todos
** List any todo items necessary before merging, if any. Delete if none. **
Tasks
** Link to task(s) which this PR corresponds to. Example: KNO-54 **
Screenshots
** Attach any screenshots or recordings to visually illustrate the changes, as necessary. Delete if not relevant. **