feat: fix quick-start navigation on land page - avoid redirection#1431
Open
BenaventeX24 wants to merge 1 commit into
Open
feat: fix quick-start navigation on land page - avoid redirection#1431BenaventeX24 wants to merge 1 commit into
BenaventeX24 wants to merge 1 commit into
Conversation
|
@BenaventeX24 is attempting to deploy a commit to the Knock Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Quick Start page not loading when clicked from link
Screenshots
Screen.Recording.2026-05-08.at.3.40.56.PM.mov
So what I found:
Next router handles the redirection of _next/data requests inconsistently between environments. In both
next devandnext startlocal environments, the router falls back to a full-page navigation when the fetch is first redirected. (it looses SPA but works basically).In production, this fallback is not happening; instead, a client-side exception is thrown.
This PR sidesteps the inconsistency by updating the card links to the legit destination url directly, avoiding the redirect. The root cause could be on Vercel's or Nextjs's side IMO. Maybe just a simple cache thing too 🤷♂️
(Possible) Todos:
Delete content/getting-started/quick-start.mdx as it seems to be the outdated/deprecated version of content/getting-started/quick-start/general.mdx. As well as its redirection defined in next.config.js