fix signed overflow in fixed-point sample rounding before saturation - #231
Merged
fabiangreffrath merged 1 commit intoJul 18, 2026
Merged
Conversation
netliomax25-code
commented
Jul 18, 2026
Contributor
- In the fixed-point build, output_to_PCM (libfaad/output.c) and real_to_int16 (libfaad/lt_predict.c) add a rounding bias to the raw int32 sample before the saturation clamp, so a decoded sample near INT32_MAX/INT32_MIN overflows the signed addition and the wrapped value then skips the clamp, emitting a garbage sample instead of the saturated one. UBSan on an HE-AAC stream: signed-integer-overflow at output.c:491 (2147483384 + 8192) and lt_predict.c:140.
- The same rounding-before-saturation pattern is present in the 16-, 24- and 32-bit output_to_PCM cases and in real_to_int16.
- Apply the rounding bias only when it cannot overflow the int32; a value large enough to overflow saturates anyway, so valid output is unchanged. Verified byte-identical 16/24/32-bit output on LC, HE-AAC and HE-AACv2 streams, and the CMake build stays clean with -Werror=strict-aliasing. Float build is unaffected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.