cap escape length in huffman_spectral_data_2 - #228
Merged
fabiangreffrath merged 1 commit intoJul 13, 2026
Conversation
The ER/HCR escape loop was bounded only at i > 32, while the standard decoder huffman_getescape caps the escape length at i < 16. Cap the HCR loop the same way and reject i >= 16 so over-long escapes are refused as in the standard path; escapes up to length 15 decode unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Capped the loop at i < 16 and reject i >= 16, matching huffman_getescape. Escapes of length 15 or less, i.e. all well-formed streams, decode unchanged.