Skip to content

DRAFT/diagnostic: accessor benchmark never reaches a leaf node (all lookups resolve tiles) #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
sifakis wants to merge 1 commit into
base: benchmark_ReadAccessor
Choose a base branch
from
Draft

DRAFT/diagnostic: accessor benchmark never reaches a leaf node (all lookups resolve tiles) #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions nanovdb/nanovdb/benchmark/BenchAccessorCuda.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@
#include <iostream>
#include <vector>

#undef NDEBUG // Release defines NDEBUG, which would compile out the assert below
#include <cassert>

static constexpr int CHUNK = 32;

template<typename AccT>
Expand All @@ -32,8 +35,12 @@ __global__ void benchKernel(const nanovdb::NanoGrid<float>* grid,
AccT acc(grid->tree().root());
float sum = 0.0f;
const int end = min(base + CHUNK, count);
for (int i = base; i < end; ++i)
for (int i = base; i < end; ++i) {
// Probe via the root, bypassing the accessor, so cache state cannot influence it.
assert(grid->tree().root().probeLeaf(coords[i]) == nullptr &&
"Unexpected: Leaf node found at probed location");
sum += acc.getValue(coords[i]);
}
out[tid] = sum;
}

Expand All @@ -54,8 +61,13 @@ __global__ void stencilKernel(const nanovdb::NanoGrid<float>* grid,
float s = 0.0f;
for (int dz = -1; dz <= 1; ++dz)
for (int dy = -1; dy <= 1; ++dy)
for (int dx = -1; dx <= 1; ++dx)
s += acc.getValue(c + nanovdb::Coord(dx, dy, dz));
for (int dx = -1; dx <= 1; ++dx) {
const nanovdb::Coord n = c + nanovdb::Coord(dx, dy, dz);
// Probe via the root, bypassing the accessor, so cache state cannot influence it.
assert(grid->tree().root().probeLeaf(n) == nullptr &&
"Unexpected: Leaf node found at probed location");
s += acc.getValue(n);
}
out[i] = s;
}
}
Expand Down