Conversation
Adds client-side merging for two common library quirks: - Artist entries that differ only by casing (e.g. "AC/DC" vs "Ac/Dc") are combined into one A-Z list entry with a canonical display casing (most common casing, ties broken toward more uppercase then alphabetical). - Artist entries whose name matches a combination pattern like "X & Y", "X feat. Y", "X ft. Y", "X vs. Y", "X with Y" or "X, Y" have their albums also shown on each component artist's page. Both behaviors are controlled by new Settings toggles under a "Library" section (mergeCaseDuplicates, splitCollabAlbums in src/lib/stores/artistMerge.js), both default to on. Pure matching/splitting/casing logic lives in artistMergeLogic.js with unit tests. The artist index is cached in-memory via getArtistsCached() so the artist page doesn't re-fetch it.
Add a settings UI to choose which separator tokens (feat., ft., vs., with, &, ,) count as joining a combination-artist entry, and fix the default "feat." regex to correctly consume the trailing period.
Let users opt in to case-duplicate merging and collab album splitting rather than enabling them automatically.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #47
Test plan
npm test(49/49 passing, includes new artistMergeLogic tests)npm run build