Conversation
Adds a toggle (next to the queue button in the player bar) that collapses the UI into a full-screen cover-art view, with hover/tap controls for previous, play/pause, stop, and next, plus a close button or Escape to exit. A new setting (Settings > Playback > "Album art mode player bar") controls whether the seek bar, volume, and queue stay visible underneath the art, or whether the art takes the whole viewport. On the Tauri desktop app, entering the mode also shrinks the OS window to a small square and restores its size on exit (no-op on the web, where the overlay handles everything via CSS).
Add temporary notes documenting the focus-ring artifact investigation, and add outline:none to the album art toggle button as the current fix attempt.
…56) The album-art window resize on Tauri could trigger a brief WebKitGTK overlay scrollbar (from main's overflow-y), which renders above CSS layers and wasn't covered by the album art overlay. Hide the app and disable html/body overflow while album art mode is active to prevent it. Also scope album art mode to the desktop app only: hide the toggle button in the browser and remove the now-unreachable player-bar visibility setting and related code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Escapealso exits.core:windowpermissions added tosrc-tauri/capabilities/default.jsonfor this. No window-resize behavior on the web (CSS overlay only).Fixes #56.
Test plan
npm run buildandnpm testpass