Fix zero serial/time in IME-forwarded wl_keyboard::key events - #1
Closed
kkimdev wants to merge 2 commits into
Closed
Fix zero serial/time in IME-forwarded wl_keyboard::key events#1kkimdev wants to merge 2 commits into
kkimdev wants to merge 2 commits into
Conversation
…sh_msg and add tracing (google#28) Replace the open-coded extend_from_slice + (len << 16) | opcode wire assembly with the existing MessageBuilder::build_message helper wrapped in a push_msg helper. MessageBuilder produces byte-identical wire output, so this is a behavior-neutral refactor. Add structured log::trace/debug/info instrumentation to every IME handler to make the host<->guest event flow observable. This lays the groundwork (shared helpers + logging) for the follow-up IME correctness fixes without changing any protocol behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split from google#30 for easier review.
wl_keyboard::key events forwarded from the IME's on_keysym handler used
serial=0 and time=0, which can cause the guest compositor to reject or
misorder them.
Fix
serial for later use by commit_state (PR 7).
Changes