Skip to content

mime exclusion list followup - #100

Merged
kjdev merged 2 commits into
masterfrom
chore/mime-exclusion-list-followup
Aug 12, 2026
Merged

mime exclusion list followup#100
kjdev merged 2 commits into
masterfrom
chore/mime-exclusion-list-followup

Conversation

@kjdev

@kjdev kjdev commented Aug 12, 2026

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • Documentation

    • Clarified that Brotli includes built-in non-compressible MIME types.
    • Documented how to add additional exclusions through the INI setting.
  • Tests

    • Added coverage for wildcard MIME-type exclusions during CGI output compression.
    • Improved test descriptions for exact-match behavior when no custom exclusions are configured.

kjdev added 2 commits August 12, 2026 10:12
Fix wording and phrasing of the built-in list explanation.
Rename ob_exclude_001.phpt to reflect that it exercises the
built-in list without an ini setting, and add ob_exclude_004.phpt
to cover wildcard matching (audio/*). Register the new test file
in package.xml.
@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 690a8ed8-306d-4d07-9e05-4faf93e9af8a

📥 Commits

Reviewing files that changed from the base of the PR and between da3bbde and f761b4b.

📒 Files selected for processing (4)
  • README.md
  • package.xml
  • tests/ob_exclude_001.phpt
  • tests/ob_exclude_004.phpt

📝 Walkthrough

Walkthrough

The change documents built-in and configurable MIME exclusions, renames an existing exclusion test, adds wildcard exclusion coverage for CGI output compression, and includes the new test in the package manifest.

Changes

Compression exclusion behavior

Layer / File(s) Summary
Exclusion contract and validation
README.md, tests/ob_exclude_001.phpt, tests/ob_exclude_004.phpt, package.xml
The README describes built-in non-compressible MIME types and additional INI exclusions. The PHPT tests cover exact and wildcard exclusions. The package manifest includes the new test.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

  • kjdev/php-ext-brotli#98: Introduced the built-in MIME exclusion list covered by this documentation and test update.

Suggested reviewers: pavetheway91

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the pull request as a follow-up to the MIME exclusion list changes covered by the documentation and test updates.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/mime-exclusion-list-followup

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kjdev
kjdev merged commit f761b4b into master Aug 12, 2026
122 checks passed
@kjdev
kjdev deleted the chore/mime-exclusion-list-followup branch August 12, 2026 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant