test(server): add CSP header assertions for non-HTML endpoints (fixes #216)#257
Open
khaines wants to merge 1 commit into
Open
test(server): add CSP header assertions for non-HTML endpoints (fixes #216)#257khaines wants to merge 1 commit into
khaines wants to merge 1 commit into
Conversation
…216) Addresses #216 — CSP headers missing on non-HTML responses. CSP security headers were set by middleware on all routes but only tested on HTML pages. Added CSP header assertions for: - /feed.xml (XML) ✅ - /sitemap.xml (XML) ✅ - /healthz (REST) ✅ - /readyz (REST) ✅ - /metrics (dedicated port) ✅ - / (HTML) ✅ - /404 (HTML error) ✅ All 9 routes now verify CSP headers match the security policy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #216
CSP security headers were set by middleware on all routes but only tested on HTML pages. Added CSP header assertions for 9 routes across:
/nonexistent-pageTestCSPOn404/TestCSPDirectiveCompleteness/feed.xmlTestCSPOnFeedXML/sitemap.xmlTestCSPOnSitemapXML/healthzTestCSPOnHealthzEndpoint/readyzTestCSPOnReadyzEndpoint/metricsTestCSPViaMiddlewareOnMetricsServer/:1(main server)TestCSPOnSeparateMetricsPort/:1(metrics server)TestCSPViaMiddlewareOnMetricsServerAll tests assert
Content-Security-PolicyandPermissions-Policyheaders are present.CI Status
All checks green ✅