Fix v1.0.4 release regression - #13
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a v1.0.4 regression surfaced during post-merge verification by aligning scope expectations in tests and tightening user-facing troubleshooting/documentation around skill discovery and embedded MCP usage.
Changes:
- Update
skill_mcp“server not found” hint to better guide users toward embedded MCP definitions and discovery refresh. - Correct skill discovery documentation and align the scope assertion in the discovery test with the current distinct-scope behavior.
- Clarify in the README that the npm package does not install the bundled example skill into a user’s OpenCode skill roots.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/tools/skill-mcp.ts | Refines the error hint when an mcp_name is not found among loaded skills. |
| src/skill-loader.ts | Updates the discovery doc comment to reflect all supported global/project roots. |
| src/tests/skill-loader.test.ts | Adjusts the expected discovered project scope to match current behavior. |
| README.md | Clarifies Quick Start expectations for repo clone vs npm install (example skill not copied into user config). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the post-merge verification failure before publishing #9.
Verified with 25 passing tests, TypeScript build, and npm package dry-run.