Skip to content
This repository was archived by the owner on May 29, 2024. It is now read-only.

Added mark for sequenced execution. Fixes #80#107

Open
norraxx wants to merge 3 commits into
kevlened:masterfrom
norraxx:sequenced_execution
Open

Added mark for sequenced execution. Fixes #80#107
norraxx wants to merge 3 commits into
kevlened:masterfrom
norraxx:sequenced_execution

Conversation

@norraxx

@norraxx norraxx commented Nov 19, 2021

Copy link
Copy Markdown

Added option to mark tests, that shouldn't be executed in parallel mode.

Via: #80

@alfredo-f

Copy link
Copy Markdown

I love this!

How were you able to test this new feature?

@norraxx

norraxx commented Mar 13, 2022

Copy link
Copy Markdown
Author

I've downloaded the project, checkout the branch, builded it, installed it, runned tests.

@alfredo-f

Copy link
Copy Markdown

I noticed #92 by @svetlyak40wt implemented a similar feature, and the unit test

tests/test_no_parallel.py

was added. Have you done something similar?

@norraxx

norraxx commented Mar 13, 2022

Copy link
Copy Markdown
Author

Oh I see what you're asking for. Nope :-) There is no any test for this feature. Should I add it?

@alfredo-f

Copy link
Copy Markdown

Well it would be a huge plus if you could demonstrate that the feature actually works 🚀

@norraxx

norraxx commented Mar 13, 2022

Copy link
Copy Markdown
Author

Ok, but you'll have to wait, give me some time for it. :-)

@norraxx

norraxx commented Mar 24, 2022

Copy link
Copy Markdown
Author

First of all, tests as they are in the repository are not working on python3.8.

  1. class ThreadLocalFixtureDef is fighting with pytest tmp_path_factory fixture, during the the fixture intialization phase. https://github.com/pytest-dev/pytest/blob/main/src/_pytest/fixtures.py#L1036. If I comment the line, tests will run.
  2. test_pytest_html and test_collection_collect_only are broken

Added the simple test.

@norraxx
norraxx force-pushed the sequenced_execution branch from 2049b4b to 3ad9a34 Compare March 24, 2022 16:33
@norraxx
norraxx force-pushed the sequenced_execution branch from 3ad9a34 to 28441a1 Compare March 24, 2022 16:34
@norraxx

norraxx commented May 4, 2022

Copy link
Copy Markdown
Author

@alfredo-f ping

@alfredo-f

Copy link
Copy Markdown

Lgtm

@norraxx

norraxx commented Jul 26, 2022

Copy link
Copy Markdown
Author

@kevlened Is this reporistory is not maintained anymore?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants