Show a notice when a field value was rejected - #21
Open
masnwilliams wants to merge 2 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
masnwilliams
marked this pull request as ready for review
August 2, 2026 18:41
masnwilliams
force-pushed
the
hypeship/replace-existing-field-notice
branch
from
August 5, 2026 23:12
7ab0711 to
0a99efa
Compare
masnwilliams
force-pushed
the
hypeship/replace-existing-field-notice
branch
from
August 5, 2026 23:31
0a99efa to
bc63cd6
Compare
masnwilliams
force-pushed
the
hypeship/replace-existing-field-notice
branch
from
August 5, 2026 23:44
bc63cd6 to
32fd50b
Compare
masnwilliams
force-pushed
the
hypeship/replace-existing-field-notice
branch
from
August 14, 2026 17:03
32fd50b to
334f881
Compare
masnwilliams
force-pushed
the
hypeship/replace-existing-field-notice
branch
from
August 20, 2026 20:06
334f881 to
88003e5
Compare
masnwilliams
force-pushed
the
hypeship/replace-existing-field-notice
branch
from
August 20, 2026 20:12
88003e5 to
1ceef72
Compare
masnwilliams
force-pushed
the
hypeship/replace-existing-field-notice
branch
from
August 20, 2026 20:27
1ceef72 to
bd66c28
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
reason: "missing" | "rejected"reason === "rejected"fieldRejectedNoticeandinputRejectedNoticecustomization points@onkernel/sdk@0.93.0This removes the temporary public
replace_existingshape entirely.stack
testing
bun run testbun run typecheckbun run buildbun run format:checkcd packages/managed-auth-react && npm pack --dry-runmanaged-auth-hosted-uibun run test,bun run typecheck,bun run lint,bun run build,bun run format:checkNote
Medium Risk
Touches managed-auth protocol types and the login form’s field projection. Behavior is additive UI plus a required
reasonon canonical fields, not auth/session security logic.Overview
Canonical managed-auth fields now require
reason: "missing" | "rejected". When a field isrejected, the form shows a localized notice so users know to enter a new value.fieldsFromCanonicalcarriesreasoninto the rendered field and still pulls placeholder/hint from coexisting legacydiscovered_fields. Customization is viafieldRejectedNoticeand theinputRejectedNoticeappearance slot (danger-colored).Vendored protocol types are checked against
@onkernel/sdk@0.93.0, and the README install line includes the SDK.Reviewed by Cursor Bugbot for commit bd66c28. Bugbot is set up for automated code reviews on this repo. Configure here.