-
Notifications
You must be signed in to change notification settings - Fork 81
Add explicit display backend configuration #345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
chruffins
wants to merge
9
commits into
main
Choose a base branch
from
hypeship/wayland-display-backend
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
3cb555f
Add explicit display backend configuration
chruffins b2e85a8
Add native Wayland startup and browser controls
chruffins 2bc6c32
Capture Wayland telemetry screenshots through CDP
chruffins e2bbb21
Route Wayland drag actions through CDP
chruffins 3c10497
Reuse CDP sessions for Wayland input sequences
chruffins 793b3fb
Reuse CDP sessions for Wayland key sequences
chruffins 5a7066d
Record Wayland frames through CDP
chruffins c415be4
Add Weston Wayland capture helper
chruffins a38b174
Enable Wayland WebRTC with Neko capture
chruffins File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| #!/bin/sh | ||
| set -eu | ||
|
|
||
| if [ "${DISPLAY_BACKEND:-x11}" = "wayland" ]; then | ||
| export NEKO_DESKTOP_WAYLAND=true | ||
| export NEKO_CAPTURE_VIDEO_WAYLAND=true | ||
| export NEKO_CAPTURE_VIDEO_WAYLAND_RECORDER=/usr/local/bin/weston-capture | ||
| fi | ||
|
|
||
| exec /usr/bin/neko serve --server.static /var/www --server.bind 0.0.0.0:8080 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| [program:weston] | ||
| command=/bin/bash -c 'exec weston --backend=headless-backend.so --use-pixman --debug --shell=desktop-shell.so --socket="${WAYLAND_DISPLAY:-wayland-0}" --width="${WIDTH:-1920}" --height="${HEIGHT:-1080}" --idle-time=0' | ||
| autostart=false | ||
| autorestart=true | ||
| startsecs=0 | ||
| stdout_logfile=/var/log/supervisord/weston | ||
| redirect_stderr=true | ||
| user=kernel | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Desktop shell restores window chrome
Medium Severity
Switching Weston from
kiosk-shell.sotodesktop-shell.sodrops the always-fullscreen kiosk behavior. Desktop shell defaults to a top panel and window decorations, so Chromium no longer fills the configuredWIDTH×HEIGHToutput. Compositor capture then includes that chrome, and CDP viewport size can fall short of the intended display (for example 1920×1024 versus 1920×1080).Reviewed by Cursor Bugbot for commit c415be4. Configure here.