Add Windows guest control and ConPTY - #431
Open
sjmiller609 wants to merge 20 commits into
Open
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
sjmiller609
force-pushed
the
hypeship/windows-guest-control
branch
2 times, most recently
from
August 20, 2026 14:14
c5bc68c to
0d96de5
Compare
sjmiller609
force-pushed
the
hypeship/windows-guest-control
branch
from
August 20, 2026 15:42
0d96de5 to
73fd1af
Compare
sjmiller609
force-pushed
the
hypeship/windows-guest-control
branch
from
August 20, 2026 16:46
73fd1af to
7cd7a6e
Compare
sjmiller609
commented
Aug 20, 2026
sjmiller609
commented
Aug 20, 2026
sjmiller609
commented
Aug 20, 2026
sjmiller609
commented
Aug 20, 2026
sjmiller609
commented
Aug 20, 2026
sjmiller609
commented
Aug 20, 2026
sjmiller609
commented
Aug 20, 2026
sjmiller609
commented
Aug 20, 2026
sjmiller609
force-pushed
the
hypeship/windows-guest-control
branch
from
August 20, 2026 18:29
0c1d3e4 to
1487012
Compare
sjmiller609
force-pushed
the
hypeship/windows-guest-control
branch
from
August 20, 2026 20:25
1487012 to
96a8dd9
Compare
sjmiller609
force-pushed
the
hypeship/windows-guest-control
branch
from
August 20, 2026 23:41
96a8dd9 to
38cabf0
Compare
sjmiller609
force-pushed
the
hypeship/windows-guest-control
branch
from
August 21, 2026 00:13
38cabf0 to
0886125
Compare
sjmiller609
marked this pull request as ready for review
August 21, 2026 00:31
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 2dfae88. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

summary
Runningwhen guest-agent readiness is provenlib/system/README.mdtargeted tests
Additional terminal signal-parity work is intentionally deferred. Long-running KVM and full CI suites were not run for this review pass.
Note
High Risk
Touches guest command execution, Windows tokens/desktop sessions, and vsock transport—security-sensitive guest control with new process-lifetime semantics.
Overview
Windows VMs now run the same guest-agent protocol as Linux. The agent is cross-compiled as
hypeman-guest-agent.exe, installed as theHypemanGuestAgentLocalSystem service, and listens on virtio-win VioSock (port 2222). Windows instances no longer skip the guest agent; readiness can mark themRunning.Exec gains an explicit
session(systemvsdesktop). SYSTEM uses the service account; DESKTOP impersonates the active interactive user onwinsta0\default. Interactive TTY uses ConPTY (SYSTEM only). Commands start suspended, join a kill-on-close Job Object, then resume so timeouts and RPC close tear down the whole process tree.Copy/stat/shutdown work on Windows (ownership and network reconfigure are no-ops/unimplemented). The exec API defaults Windows shells to
cmd.exe. CI builds the Windows agent and adds a QEMU guest-control integration gate.Reviewed by Cursor Bugbot for commit 1f60d0a. Bugbot is set up for automated code reviews on this repo. Configure here.