Skip to content

Fix wav header and mime type, add playback time to record callback, add types#9

Open
niklasdahlheimer wants to merge 9 commits into
keithwhor:mainfrom
niklasdahlheimer:main
Open

Fix wav header and mime type, add playback time to record callback, add types#9
niklasdahlheimer wants to merge 9 commits into
keithwhor:mainfrom
niklasdahlheimer:main

Conversation

@niklasdahlheimer
Copy link
Copy Markdown

This pull requests

fixes:

  • wrong mime type for blob (audio/wav instead of audio/mpeg)
  • wrong wav header: riffChunkSize was hardcoded to 52 byte, but should represent total file size - 8 bytes (see specification ) and make it better readable by extracting variables

adds:

  • missing types (lots of any types replaced by actual type)
  • playback time to record callback: maybe there is a better way to handle this, but some sort of current recording time should be available

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant