Removing pedantic flag - #28
Open
JiaT75 wants to merge 3 commits into
Open
Conversation
|
Danger. The author of this PR is a known malicious actor. |
|
The user has been observed weakening warnings, presumably so that any exploits they create go unnoticed. I wouldn't accept this. |
|
not only the warnings, the commit 7978e54 "Added configure to .gitignore since it should be regenerated" adds |
johnzhou721
reviewed
Jun 15, 2025
| bin/ | ||
| config.log | ||
| config.status | ||
| configure |
There was a problem hiding this comment.
It's malicious, you're going to take over make a release with changed configure
| config.log | ||
| config.status | ||
| configure | ||
| autom4te.cache/ No newline at end of file |
There was a problem hiding this comment.
Suggested change
| autom4te.cache/ | |
| autom4te.cache/ | |
| # I am not sure what effect that has really. - guidod | ||
| for ac_arg dnl | ||
| in "-pedantic % -Wall -ansi -pedantic" dnl GCC | ||
| in "-ansi % -Wall -ansi" dnl GCC |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pedantic flag is not compatible with the FUNCTION macro extension. This fix will remove the warnings generated when compiling.